Thermostat fix #1867
Merged
Thermostat fix #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
zsarnett
force-pushed
the
thermostat-fix
branch
from
96f49f3 to
aaba9be
Compare
balloob
reviewed
Oct 26, 2018
| @@ -73,11 +74,13 @@ export class HuiThermostatCard extends hassLocalizeLitMixin(LitElement) | |||
| [stateObj.attributes.operation_mode]: true, | |||
There was a problem hiding this comment.
This will fail if operation mode contains a space.
2 tasks
balloob
reviewed
Oct 26, 2018
| })}"> | ||
| <div id="root"> | ||
| <div id="thermostat"></div> | ||
| <div id="tooltip"> | ||
| <div class="title">Upstairs</div> | ||
| <div class="title">${this.config.title}</div> |
There was a problem hiding this comment.
Why do we use config.title and not the entity name ?
thomasloven
reviewed
Oct 26, 2018
| @@ -30,6 +31,7 @@ const modeIcons = { | |||
|
|
|||
| interface Config extends LovelaceConfig { | |||
| entity: string; | |||
| title: string; | |||
There was a problem hiding this comment.
Forgot to remove this again?
thomasloven
approved these changes
Oct 26, 2018
balloob
pushed a commit
that referenced
this pull request
Oct 27, 2018
* Thermostat fix * Fix for unknown operation mode * No title for you * I suck at removing unnecessary things * Fixing pointless Ternary operator
zsarnett
added a commit
that referenced
this pull request
Oct 29, 2018
* Thermostat fix * Fix for unknown operation mode * No title for you * I suck at removing unnecessary things * Fixing pointless Ternary operator
balloob
pushed a commit
that referenced
this pull request
Oct 29, 2018
* Thermostat fix (#1867) * Thermostat fix * Fix for unknown operation mode * No title for you * I suck at removing unnecessary things * Fixing pointless Ternary operator * Add version bump script * Fix hass setting on stack (#1868) * Fix hass setting on stack * Don't set hass on pic elements if undefined * Don't set hass on entity rows if undefined * prefix config prop * Pic elements set hass yoooo * Remove interface * Make stack config private * Fix import * Lint * Bumped version to 20181026.1 * 🔨 move not text to header and name to secondary text * 🔨 reduce some other margins
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing at developing and Fixing my noob mistakes